-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Run update-packages #99038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run update-packages #99038
Conversation
86a49dc to
651ac1f
Compare
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, however, we still have cli_util
651ac1f to
37fa7e0
Compare
dev/tools/dartdoc.dart
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided this should be reverted from #99037 since cli_util is still a dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-(
|
Uh oh, this looks like it could be a regression: |
37fa7e0 to
ce09a9c
Compare
|
Rebased onto #99075 |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: rolling dependencies |
ce09a9c to
af8c18f
Compare
|
Rebased onto #99079. |
Run
flutter update-packages --force-upgradePre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.