Skip to content

Remove cli_utils from allow-list #99037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Feb 24, 2022
Merged

Remove cli_utils from allow-list #99037

jmagman merged 2 commits into from
Feb 24, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 24, 2022

Remove cli_utils from the SDK package allowlist.
Fixes #99036

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Feb 24, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 24, 2022
@jmagman jmagman mentioned this pull request Feb 24, 2022
Merged
8 tasks
@jmagman jmagman requested a review from devoncarew February 24, 2022 02:12
@jmagman
Copy link
Member Author

jmagman commented Feb 24, 2022

Does this also need to be removed?

flutter/dev/tools/dartdoc.dart

Line 176 in 533a5dd

'cli_util',

gspencergoog
gspencergoog approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@jmagman
Copy link
Member Author

jmagman commented Feb 24, 2022

The interesting tests have passed, we don't need to wait for Google testing and gold for this fix. Merging to reopen the tree.

@jmagman jmagman merged commit 0eae276 into flutter:master Feb 24, 2022
@jmagman jmagman deleted the cli_utils branch February 24, 2022 02:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
e214378
This was referenced Feb 24, 2022
Closed
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
bb8442c
@devoncarew devoncarew mentioned this pull request Feb 24, 2022
Closed
@jmagman jmagman mentioned this pull request Feb 24, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
d6b59fb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
33ac251
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
b0dc218
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
5c7a233
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
f1ce0a7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
50cb726
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
1182d19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
afc74ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
e95ca66
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
d1c1d09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
287af0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
8a2eb32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
dbb4872
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
d0ab88c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
f3d0986
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
8ec412e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
2e05fcc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
589fab7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
0eae276 Remove cli_utils from allow-list (flutter/flutter#99037)
da746cb
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Remove cli_utils from allow-list (flutter#99037)
35333b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@Hixie Hixie Awaiting requested review from Hixie

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@devoncarew devoncarew Awaiting requested review from devoncarew

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analyzer failing on Excellent news! A package dependency has been removed! cli_util

2 participants

@jmagman @gspencergoog