Skip to content

Assert golden files use the right extension #99016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Feb 24, 2022
Merged

Assert golden files use the right extension #99016

fluttergithubbot merged 5 commits into from
Feb 24, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 23, 2022

Fixes #98943
This ensures golden files in the framework always have the file extension included.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 23, 2022
@Piinks Piinks requested a review from goderbauer February 23, 2022 19:16
goderbauer
goderbauer approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter_goldens/test/flutter_goldens_test.dart
);
});

test('asserts .png format', () async {
Copy link
Member

@goderbauer goderbauer Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rewrite these with the throwsA type matcher using having similarly to how it is done in:

flutter/packages/flutter/test/gestures/monodrag_test.dart

Line 60 in ab89ce2

throwsA(
. Unlike that example, you may have to use await expectLater since the call is async here.

In general, I find that style less error prone (because the fail call is easy to forget) and a little clearer in its intention.

Copy link
Contributor Author

@Piinks Piinks Feb 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thank you! I was patting myself on the back for remembering the fail, while simultaneously trying to remember the better way to do it. 😜
Will update.

goderbauer
goderbauer reviewed Feb 23, 2022
View reviewed changes
packages/flutter_goldens/test/flutter_goldens_test.dart Outdated
});

test('asserts .png format', () async {
expectLater(
Copy link
Member

@goderbauer goderbauer Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you have to await these, no?

@fluttergithubbot fluttergithubbot merged commit ee86e61 into flutter:master Feb 24, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
dbdba6d 
…99016)
harryterkelsen pushed a commit that referenced this pull request Feb 24, 2022
Revert "Assert golden files use the right extension (#99016)"
37f99cb 
This reverts commit ee86e61.
@harryterkelsen harryterkelsen mentioned this pull request Feb 24, 2022
Merged
harryterkelsen pushed a commit that referenced this pull request Feb 24, 2022
Revert "Assert golden files use the right extension (#99016)" (#99075)
735f9ab 
This reverts commit ee86e61.
@Piinks Piinks mentioned this pull request Feb 24, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
328aaf1 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
1173bbe 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
598c613 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
f166ba7 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
27d511a 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
6ae028d 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
f80ad86 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
cbfb63e 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
84d748d 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
b0d7803 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
2279d08 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
1b9fa5c 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
62509af 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
9f24c7b 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
dd92b1e 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
4356a6d 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
5d58a4c 
…99016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
ee86e61 Assert golden files use the right extension (flutter/flutter#…
a90d552 
…99016)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Piinks @clocksmith
Assert golden files use the right extension (flutter#99016)
c125141
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Revert "Assert golden files use the right extension (flutter#99016)" (f…
3ae17fb 
…lutter#99075)

This reverts commit ee86e61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Framework's matchesGoldenFile should assert that file name has right structure

3 participants

@Piinks @goderbauer @fluttergithubbot