Skip to content

Deflake Mac module_test_ios #99009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 25, 2022
Merged

Deflake Mac module_test_ios #99009

fluttergithubbot merged 1 commit into from
Feb 25, 2022

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Feb 23, 2022

Deflake module_test_ios as no flake in recent 100 commits.

#89175

@keyonghan keyonghan mentioned this pull request Feb 23, 2022
Closed
@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 23, 2022
cyanglaz
cyanglaz approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Feb 24, 2022

It hit #97303, try rebasing onto #98297 ?
https://ci.chromium.org/p/flutter/builders/try/Mac%20module_test_ios/12058?

See also #99039 for the other simulator infra issue we're seeing.

@keyonghan keyonghan force-pushed the deflake_module_test_ios branch from 9a7b3f7 to 554f556 Compare February 24, 2022 17:24
@jmagman
Copy link
Member

jmagman commented Feb 24, 2022

Well module_test_ios passed but now you need to rebase on #99075. Are we having fun yet? 🙂

@jmagman jmagman mentioned this pull request Feb 24, 2022
Closed
@keyonghan keyonghan force-pushed the deflake_module_test_ios branch from 554f556 to 2907d7b Compare February 24, 2022 21:11
@fluttergithubbot fluttergithubbot merged commit c7f07bb into flutter:master Feb 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
f0c7e4c
@jmagman jmagman mentioned this pull request Feb 25, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
477dc4a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
9b0432e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
356384f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
2333bc0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 26, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
ce76dce
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
16c66ac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
1e31d70
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
1515e50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
6635c5b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
12537ac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
81a7020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
c8677ae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
df6dcf7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
ca718fe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
0156de1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
45e725f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
d60fa52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
bbb053e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
c7f07bb Deflake Mac module_test_ios (flutter/flutter#99009)
efe9438
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@keyonghan @clocksmith
Deflake Mac module_test_ios (flutter#99009)
7304bbf
@keyonghan keyonghan deleted the deflake_module_test_ios branch April 25, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

+1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keyonghan @jmagman @cyanglaz @goderbauer @fluttergithubbot