Skip to content

Use int for PlaceholderSpan.placeholderCodeUnit #98971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 23, 2022
Merged

Use int for PlaceholderSpan.placeholderCodeUnit #98971

fluttergithubbot merged 1 commit into from
Feb 23, 2022

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented Feb 23, 2022

This PR changes the type of PlaceholderSpan.placeholderCodeUnit introduced in #98542 to int so as to avoid conversions.

Text exempt - optimisation only.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 23, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 23, 2022
@tgucio tgucio mentioned this pull request Feb 23, 2022
Merged
8 tasks
@Hixie
Copy link
Contributor

Hixie commented Feb 23, 2022

test-exempt: code refactor with no semantic change

@goderbauer goderbauer requested a review from chunhtai February 23, 2022 22:36
goderbauer
goderbauer approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunhtai
chunhtai approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 9e7cc97 into flutter:master Feb 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
170be26 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
7ad06eb 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
1e73cc8 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
b1134fe 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
9a491b5 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
47fbb91 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
cbea667 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
3527523 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
114fe6f 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
41a0282 
…ter#98971)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 26, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
267209a 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
27cc164 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
2a9e0d7 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
7e01b44 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
c77dff9 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
494c66b 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
c565747 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
32878f9 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
2e89c36 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
bc12d91 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
fa8ac4b 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
8fd064a 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
958180b 
…ter#98971)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
5093cc9 
…ter#98971)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
2621bbd 
…ter#98971)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9e7cc97 Use int for PlaceholderSpan.placeholderCodeUnit (flutter/flut…
4e512da 
…ter#98971)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@tgucio @clocksmith
Use int for PlaceholderSpan.placeholderCodeUnit (flutter#98971)
a30db03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tgucio @Hixie @goderbauer @chunhtai @fluttergithubbot