This PR fixed the problem that has prevented daemon_test.dart being shuffled. Part of #85160.

The issues

Two issues were found related to three tests. No test failed for me using the reported seed 1000. But it failed on seed 123.

Test A: 'notifyingLogger outputs trace messages in verbose mode'
Test B: 'notifyingLogger ignores trace messages in non-verbose mode'
Test C: 'notifyingLogger buffers messages sent before a subscription'

First Issue - Order Dependency

All three tests use the bufferLogger variable that is initialized inside group 'daemon'. As these
three tests are placed outside that group, they were failing if run before the group 'daemon'.

Second Issue - Broken Test and Order Dependency

As far as I can see, the test B has never been working as intended.
The line 'logger.printTrace('test');' should not be logged in bufferLogger in non-verbose mode. The test expected it to be logged.

It was working though because test A was logging the same string to bufferLogger and leaving the log behind for later tests. But if test B was run before test A, it would fail.

The fix

First issue

Create a new test group called 'notifyingLogger' to initialize bufferLogger and then clear it, after each of these tests. The bufferLogger variable was isolated in each group to avoid future mistakes.

Second Issue

Test B was changed to expect the bufferLogger to be empty.

Note

I could not reproduce any test failings on randomize ordering seed 1000. I found these issues using seed 123.
Any reviewer should consider testing seed 1000 to make sure there is no race condition that I cannot reproduce.

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
• I signed the [CLA].
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is [test-exempt].
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].