Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 23, 2022

Help debug #98419. Added a 10 second timer to start logging events if the first frame is not detected.

A very similar 10 second timeout was removed in #26736, but this just logs the events we're received, and the isolate ID of the views.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Feb 23, 2022
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 23, 2022
@jmagman jmagman force-pushed the trace-first-frame-timeout branch from d46c698 to 6197769 Compare February 25, 2022 22:58
@jmagman jmagman changed the title Timeout when first frame not detected on trace, add logging Print events and views when first frame is taking awhile during tracing Feb 25, 2022
@jmagman jmagman force-pushed the trace-first-frame-timeout branch from 6197769 to 7f55aff Compare February 25, 2022 22:59
@jmagman jmagman force-pushed the trace-first-frame-timeout branch from 7f55aff to ef932c9 Compare February 25, 2022 23:10
@fluttergithubbot fluttergithubbot merged commit c80ff45 into flutter:master Feb 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants