Skip to content

Fixed some issues and clarified the docs for ReorderableListView. #98954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 2 commits into from
Feb 23, 2022
Merged

Fixed some issues and clarified the docs for ReorderableListView. #98954

darrenaustin merged 2 commits into from
Feb 23, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Feb 22, 2022 •
edited
Loading

This is a replaces #86737 (thx @idkq!) and clarifies the constructor documentation for ReorderableListView.

This should help with #80553.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 22, 2022
@darrenaustin darrenaustin mentioned this pull request Feb 22, 2022
Closed
Piinks
Piinks approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit! :)

@darrenaustin darrenaustin merged commit 3f52d58 into flutter:master Feb 23, 2022
@darrenaustin darrenaustin deleted the reorderable_list_doc branch February 23, 2022 01:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
3f52d58 Fixed some issues and clarified the docs for ReorderableListV…
53e1c2e 
…iew. (flutter/flutter#98954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
3f52d58 Fixed some issues and clarified the docs for ReorderableListV…
3bc85e7 
…iew. (flutter/flutter#98954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
3f52d58 Fixed some issues and clarified the docs for ReorderableListV…
0dfabfe 
…iew. (flutter/flutter#98954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
3f52d58 Fixed some issues and clarified the docs for ReorderableListV…
b0f958f 
…iew. (flutter/flutter#98954)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@darrenaustin @clocksmith
Fixed some issues and clarified the docs for ReorderableListView. (fl…
2171df2 
…utter#98954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darrenaustin @Piinks