Remove redundant hide handles API from TextSelectionDelegate #98944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
justinmc
approved these changes
Feb 22, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
That's great that we can reduce this API surface. We should watch out for this breaking any customers.
I agree that this can't be tested as far as I'm aware.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2022
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Feb 23, 2022
…lutter#98944)" This reverts commit 94f6fd6.
8 tasks
chunhtai
added a commit
that referenced
this pull request
Feb 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 23, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
…lutter#98944)" (flutter#99008) This reverts commit 94f6fd6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method only used internally in editableText or directly called on EditableText without going through TextSelectionDelegate interface.
Removing this makes it easier to reuse SelectionOverlay
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.