Skip to content

Update regexp for Observatory/VM Service message parsing for device lab #98935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkonyi merged 1 commit into from
Feb 22, 2022
Merged

Update regexp for Observatory/VM Service message parsing for device lab #98935

bkonyi merged 1 commit into from
Feb 22, 2022
+1 −1

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Feb 22, 2022

Should unblock #98930

@bkonyi bkonyi requested a review from iskakaushik February 22, 2022 17:52
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 22, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 22, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bkonyi bkonyi mentioned this pull request Feb 22, 2022
Closed
iskakaushik
iskakaushik approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a-siva
a-siva approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@a-siva a-siva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess once a Dart roll with the new VM service string rolls into the framework we can drop Observatory from the regexp.

@bkonyi bkonyi merged commit 729f8c8 into master Feb 22, 2022
@bkonyi bkonyi deleted the fix_roll branch February 22, 2022 18:59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
729f8c8 Update regexp for Observatory/VM Service message parsing for …
2612fe8 
…device lab (flutter/flutter#98935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
729f8c8 Update regexp for Observatory/VM Service message parsing for …
d8772e3 
…device lab (flutter/flutter#98935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
729f8c8 Update regexp for Observatory/VM Service message parsing for …
474d9b5 
…device lab (flutter/flutter#98935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
729f8c8 Update regexp for Observatory/VM Service message parsing for …
1e7a236 
…device lab (flutter/flutter#98935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
729f8c8 Update regexp for Observatory/VM Service message parsing for …
301796b 
…device lab (flutter/flutter#98935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
729f8c8 Update regexp for Observatory/VM Service message parsing for …
ed820df 
…device lab (flutter/flutter#98935)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@bkonyi @clocksmith
Update regexp for Observatory/VM Service message parsing for device l…
ca9b61f 
…ab (flutter#98935)

Should unblock flutter#98930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@a-siva a-siva a-siva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkonyi @iskakaushik @a-siva