Skip to content

[dap] Don't use --start-paused when running in Profile/Release mode #98926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 8 commits into from
Feb 25, 2022
Merged

[dap] Don't use --start-paused when running in Profile/Release mode #98926

fluttergithubbot merged 8 commits into from
Feb 25, 2022

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 22, 2022

This change mirrors a fix made in the legacy VS Code extension DAP for Dart-Code/Dart-Code#3838.

The issue is that we were using --start-paused in profile mode which would cause a short delay when new isolates were spawned (because they would start paused and wait for us to unpause them). For some measurements of time (including a simple stopwatch) this could make code that uses isolates appear to be slower than it really is.

There was no need to use --start-paused for profile mode since debugging functionality is disabled (so we are not concerned about races in setting up breakpoints, etc.) so this simple skips it in those cases.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 22, 2022
christopherfujino
christopherfujino reviewed Feb 22, 2022
View reviewed changes
packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. this sentence is awkward. should it be "This is always true for attach requests."?

Copy link
Contributor Author

@DanTup DanTup Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Awkward is an understatement 😄 Fixed!

@DanTup
Copy link
Contributor Author

DanTup commented Feb 23, 2022

@christopherfujino there doesn't seem to be much info about the failure here:

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20framework_tests_misc/13487/overview

@christopherfujino christopherfujino mentioned this pull request Feb 24, 2022
Closed
@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 24, 2022

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20framework_tests_misc/13487/overview

I'm guessing this was an infra failure, the swarming task page just says "bot died" https://chromium-swarm.appspot.com/task?id=593f4101f7b6cb10&o=true&w=true

christopherfujino
christopherfujino approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. the analysis error will be fixed by rebasing upstream.

@fluttergithubbot fluttergithubbot merged commit 76758ef into flutter:master Feb 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
d00b5b8 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
56fc0c5 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
3b8b3a3 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
ef9ff5b 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
18517b6 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
0f4fa2d 
…e mode (flutter/flutter#98926)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
82faad8 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
4ed50ce 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
0a9e812 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
db2765f 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
8e6557e 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
8edf259 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
b3a05b0 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
75c05c1 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
e2adf40 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
ec7d116 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
a49b55c 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
9d5f6a5 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
e9bca07 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
3433a03 
…e mode (flutter/flutter#98926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
76758ef [dap] Don't use --start-paused when running in Profile/Releas…
d07fb82 
…e mode (flutter/flutter#98926)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@DanTup @clocksmith
[dap] Don't use --start-paused when running in Profile/Release mode (f…
cb8a656 
…lutter#98926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanTup @christopherfujino @fluttergithubbot