Skip to content

Avoid unnecessary lambdas in SelectionOverlay.showHandles() #98912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 22, 2022
Merged

Avoid unnecessary lambdas in SelectionOverlay.showHandles() #98912

fluttergithubbot merged 1 commit into from
Feb 22, 2022

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented Feb 22, 2022 •
edited
Loading

Replaces #98409 (closed due to rebase error).

This PR removes the unnecessary lambdas in SelectionOverlay method showHandles().

No functional changes.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 22, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 22, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tgucio
Copy link
Contributor Author

tgucio commented Feb 22, 2022

@goderbauer @Hixie @cbracken @dkwingsmt
This one is #98409 again for approval and test-exempt. I closed #98409 as after rebase on an old branch things didn't look great.

goderbauer
goderbauer approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit cd2413c into flutter:master Feb 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
e5dd6e3 
…lutter/flutter#98912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
958d00c 
…lutter/flutter#98912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
bc8b099 
…lutter/flutter#98912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
a38cd9b 
…lutter/flutter#98912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
1abdeb0 
…lutter/flutter#98912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
fb57efd 
…lutter/flutter#98912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
cd2413c Avoid unnecessary lambdas in SelectionOverlay.showHandles() (f…
4fe30ae 
…lutter/flutter#98912)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@tgucio @clocksmith
Avoid unnecessary lambdas in SelectionOverlay.showHandles() (flutter#…
07f72f2 
…98912)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgucio @goderbauer @dkwingsmt @fluttergithubbot