Add gradle wrapper to new project template. #9882
Conversation
abarth
left a comment
abarth
left a comment
There was a problem hiding this comment.
Please do not check in binary files, such as gradle-wrapper.jar.
I'm also skeptical about the gradlew shell script. For example, what happens when that file changes?
|
I'll share some context on this change in a few hours |
|
Before we add more files to the template, I think we should make sure the template contains a README that documents, for each file in the template:
The template is growing really big and it's not at all clear why some of these files are part of the user code and not just part of the framework. |
|
Some additional notes are available in go/gradlenotes |
|
You could do gradle wrapper to generate gradle wrapper. It supposed to take gradle version from the wrapper function in a build.gradle. |
|
This is being tracked in #10236. Should we close this PR for now, since it seems this is not going to land as-is? |
|
We can close this PR, yes, but lets track the work in the existing bug #9842, please |
6 participants
Android Studio is heavily pushing the Gradle wrapper when you open our projects in Studio. It's also pushing an upgrade to the gradle plugin, which requires Gradle 3.3. However, Studio ships with Gradle 3.2, so if you choose to upgrade, the project will not build.
Using the gradle wrapper makes Studio happier, so let's update our new project template to use it.
We could also update our build.gradle to require v2.3.1 of the Android Gradle plugin, so Studio won't prompt to upgrade the dependency for us, but I've left that for another change.
Fixes #9842.