Skip to content

Add more tests to slider to avoid future breakages #98772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Feb 19, 2022
Merged

Add more tests to slider to avoid future breakages #98772

fluttergithubbot merged 3 commits into from
Feb 19, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 18, 2022

Having these tests in the framework would have avoided the breakage that #98219 caused in google3.

See also: #98770.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 18, 2022
@skia-gold
Copy link

skia-gold commented Feb 18, 2022

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/98772

@skia-gold
Copy link

skia-gold commented Feb 18, 2022

Gold has detected about 4 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/98772

jonahwilliams
jonahwilliams approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer mentioned this pull request Feb 18, 2022
Open
@skia-gold
Copy link

skia-gold commented Feb 18, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/98772

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 18, 2022

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #98772 at sha a255dc9

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 18, 2022
@fluttergithubbot fluttergithubbot merged commit baa2803 into flutter:master Feb 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2022
@engine-flutter-autoroll
baa2803 Add more tests to slider to avoid future breakages (flutter/f…
1bb5efe 
…lutter#98772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2022
@engine-flutter-autoroll
baa2803 Add more tests to slider to avoid future breakages (flutter/f…
ed41150 
…lutter#98772)
zanderso added a commit that referenced this pull request Feb 19, 2022
@zanderso
Revert "Add more tests to slider to avoid future breakages (#98772)"
dbd47c7 
This reverts commit baa2803.
@zanderso zanderso mentioned this pull request Feb 19, 2022
Merged
zanderso added a commit that referenced this pull request Feb 19, 2022
@zanderso
Revert "Add more tests to slider to avoid future breakages (#98772)" (#…
9aed298 
…98783)

This reverts commit baa2803.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 19, 2022
@engine-flutter-autoroll
baa2803 Add more tests to slider to avoid future breakages (flutter/f…
4868012 
…lutter#98772)
goderbauer added a commit to goderbauer/flutter that referenced this pull request Feb 22, 2022
@goderbauer
Reland "Add more tests to slider to avoid future breakages (flutter#9…
400737b 
…8772)"

This reverts commit 9aed298.
This was referenced Feb 22, 2022
Merged
Closed
fluttergithubbot pushed a commit that referenced this pull request Feb 22, 2022
@goderbauer
Reland "Add more tests to slider to avoid future breakages (#98772)" (#…
79d435d 
…98936)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@goderbauer @clocksmith
Add more tests to slider to avoid future breakages (flutter#98772)
ce433ee
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@zanderso @clocksmith
Revert "Add more tests to slider to avoid future breakages (flutter#9…
9db83a7 
…8772)" (flutter#98783)

This reverts commit baa2803.
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@goderbauer @clocksmith
Reland "Add more tests to slider to avoid future breakages (flutter#9…
a8376f7 
…8772)" (flutter#98936)
@goderbauer goderbauer deleted the moreSliderTests branch April 19, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goderbauer @skia-gold @jonahwilliams @fluttergithubbot