Added a microbenchmark for Timeline events. #98763
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
force-pushed
the
timeline-benchmark
branch
from
2d445cc to
dc9e008
Compare
|
test-exempt: is a test |
|
Looks like the checks are pretty unhappy. |
There was a problem hiding this comment.
nit: formatting. just leave this on one line, maybe?
|
Link to the Dart Timeline speedup code: https://dart-review.googlesource.com/c/sdk/+/233652 |
gaaclarke
force-pushed
the
timeline-benchmark
branch
from
dc9e008 to
1328a4a
Compare
@goderbauer Do you know what is going on with these tests? I assumed the tree was red, but it looks like things should be fine. The tests that are failing should be unrelated and they are saying things like "Could not find Java" which I didn't change. |
|
Not sure what's up with them. Maybe ask on the infra chat? |
3 participants
Minimizing the overhead for performance tracking tools should be a goal. I see there might be some room for optimization here.
Test exempt: This is a test.
cc @iskakaushik
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.