Skip to content

Enable use_if_null_to_convert_nulls_to_bools lint #98753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 6 commits into from
Feb 22, 2022
Merged

Enable use_if_null_to_convert_nulls_to_bools lint #98753

fluttergithubbot merged 6 commits into from
Feb 22, 2022

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented Feb 18, 2022 •
edited
Loading

This PR enables the use_if_null_to_convert_nulls_to_bools lint and adds relevant code changes. Fixes #98650.

Code refactor only, no functional changes: no tests required.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Feb 18, 2022
@tgucio tgucio mentioned this pull request Feb 18, 2022
Closed
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 18, 2022
goderbauer
goderbauer approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented Feb 18, 2022

@christopherfujino for the tool

christopherfujino
christopherfujino approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tools changes

@fluttergithubbot fluttergithubbot merged commit e4351ff into flutter:master Feb 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
e4351ff Enable use_if_null_to_convert_nulls_to_bools lint (flutter/fl…
8d02a8f 
…utter#98753)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
e4351ff Enable use_if_null_to_convert_nulls_to_bools lint (flutter/fl…
ac8bc51 
…utter#98753)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
e4351ff Enable use_if_null_to_convert_nulls_to_bools lint (flutter/fl…
4e52d71 
…utter#98753)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
e4351ff Enable use_if_null_to_convert_nulls_to_bools lint (flutter/fl…
7961d89 
…utter#98753)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@tgucio @clocksmith
Enable use_if_null_to_convert_nulls_to_bools lint (flutter#98753)
d25c828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider adding use_if_null_to_convert_nulls_to_bools lint

4 participants

@tgucio @goderbauer @christopherfujino @fluttergithubbot