Skip to content

fix(flutter_tools): Format gen-l10n output files with dart format #98701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelDark wants to merge 3 commits into from
Closed

fix(flutter_tools): Format gen-l10n output files with dart format #98701

MichaelDark wants to merge 3 commits into from

Conversation

@MichaelDark
Copy link

@MichaelDark MichaelDark commented Feb 17, 2022 •
edited
Loading

Format gen-l10n output with dart format

Fixes:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 17, 2022
@MichaelDark MichaelDark mentioned this pull request Feb 17, 2022
Closed
@MichaelDark
Copy link
Author

MichaelDark commented Feb 18, 2022

I would really appreciate if someone could help me with tests for this PR

christopherfujino
christopherfujino reviewed Mar 3, 2022
View reviewed changes
packages/flutter_tools/lib/src/localizations/gen_l10n.dart
import '../convert.dart';
import '../flutter_manifest.dart';

import '../globals.dart'as globals;
Copy link
Contributor

@christopherfujino christopherfujino Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import '../globals.dart'as globals;
import '../globals.dart' as globals;

@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 3, 2022

I'm unclear on whether applying this in all situations is the right thing to do. I like the idea @HansMuller proposed of allowing users to specify a filter: #98122 (comment)

@christopherfujino christopherfujino added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 17, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 24, 2022

Closing this PR as stale. If you want to land this, I would suggest starting discussion on the issue to verify the approach.

@HansMuller HansMuller reopened this May 26, 2022
@HansMuller
Copy link
Contributor

HansMuller commented May 26, 2022

We haven't been able to address this issue and PR (yet) but it's still valid. An engineer who will focus on the i18n tools is starting in a few weeks; hopefully we can make some real progress then.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 15, 2022

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@HansMuller HansMuller added the a: internationalization Supporting other languages or locales. (aka i18n) label Jun 15, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 4, 2022

cc @thkim1011

@thkim1011 thkim1011 mentioned this pull request Aug 8, 2022
Merged
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 11, 2022

@thkim1011 should we close this as superceded by #109171 ?

@thkim1011
Copy link
Contributor

thkim1011 commented Aug 19, 2022

Closing this PR as it's stale, and we decided to take a slightly different approach. See #109171.

@thkim1011 thkim1011 closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) tool Affects the "flutter" command-line tool. See also t: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelDark @christopherfujino @HansMuller @thkim1011