Skip to content

Test that render object changed its visual appearance after texture is create #98622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 4 commits into from
Feb 22, 2022
Merged

Test that render object changed its visual appearance after texture is create #98622

blasten merged 4 commits into from
Feb 22, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Feb 16, 2022 •
edited
Loading

Tests that the render object of a platform view changed its visual appearance after texture is create

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 16, 2022
@blasten blasten changed the title Mark render object as having changed visually when the textureId is set Test that render object changed its visual appearance after texture is create Feb 18, 2022
@blasten blasten marked this pull request as ready for review February 18, 2022 19:13
@blasten blasten requested a review from cyanglaz February 18, 2022 19:13
cyanglaz
cyanglaz approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit f4fc2c8 into flutter:master Feb 22, 2022
@blasten blasten deleted the pv_repaint branch February 22, 2022 22:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f4fc2c8 Test that render object changed its visual appearance after t…
e3a6aba 
…exture is create (flutter/flutter#98622)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
f4fc2c8 Test that render object changed its visual appearance after t…
510f01c 
…exture is create (flutter/flutter#98622)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
f4fc2c8 Test that render object changed its visual appearance after t…
8834698 
…exture is create (flutter/flutter#98622)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Test that render object changed its visual appearance after texture i…
835e4a2 
…s create (flutter#98622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blasten @cyanglaz