Skip to content

Increase recommended CocoaPods version to 1.11 #98621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 24, 2022
Merged

Increase recommended CocoaPods version to 1.11 #98621

fluttergithubbot merged 1 commit into from
Feb 24, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 16, 2022

I was recently hitting a plugins issue that only reproduced on CocoaPods 1.10 and not 1.11 flutter/samples#1004 (comment)

While I couldn't exactly pin down what was wrong, it seems prudent to recommend CocoaPods 1.11 (released Sept 2021) to encourage developers to start upgrading ASAP before we bump the required version.

The recommended (not required) version only impacts flutter doctor output.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 16, 2022
@jmagman jmagman self-assigned this Feb 16, 2022
jmagman
jmagman commented Feb 16, 2022
View reviewed changes
packages/flutter_tools/test/general.shard/macos/cocoapods_test.dart Outdated
Copy link
Member Author

@jmagman jmagman Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests require a sufficient version is installed. Up the version to a really high number so we don't need to change these tests every time we bump the recommended or required versions.

christopherfujino
christopherfujino approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 320d2cf into flutter:master Feb 24, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
f67f147 
…er#98621)
@jmagman jmagman deleted the min-cocoapods branch February 24, 2022 20:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
50e7c24 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
50f3d5a 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
b1ad7f7 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
ed5a976 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
cf5cbc2 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
0cd0527 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
be59480 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
24f7821 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
20de568 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
32bead6 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
8663582 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
5fbcd9e 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
53e76fe 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
97bb44b 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
810c38e 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
e25a97f 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
2f03e07 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
b10de89 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
74146cd 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
ddfd522 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
6633b78 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
d4ad33b 
…er#98621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
320d2cf Increase recommended CocoaPods version to 1.11 (flutter/flutt…
6f5c4df 
…er#98621)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Increase recommended CocoaPods version to 1.11 (flutter#98621)
5aee2db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @fluttergithubbot