Skip to content

Remove deprecated RenderObjectElement methods #98616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Mar 7, 2022
Merged

Remove deprecated RenderObjectElement methods #98616

fluttergithubbot merged 4 commits into from
Mar 7, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022

This removes the following methods from RenderObjectElement

  • insertChildRenderObject
  • moveChildRenderObject
  • removeChildRenderObject

These deprecated methods have reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes a: quality A truly polished experience c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard

This comment was marked as outdated.

Sign in to view
goderbauer
goderbauer reviewed Feb 23, 2022
View reviewed changes
@Piinks Piinks changed the title [WIP] Remove deprecated RenderObjectElement methods Remove deprecated RenderObjectElement methods Mar 3, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Mar 3, 2022

@goderbauer can you review this one again? It should be ready to go now. :)

@Piinks Piinks requested a review from goderbauer March 3, 2022 23:22
goderbauer
goderbauer approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you sooo much for cleaning this up!

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 4, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor Author

Piinks commented Mar 7, 2022

There are a few more references that came up, still migrating.

@Piinks
Copy link
Contributor Author

Piinks commented Mar 7, 2022

Ok, now we should be ready here.

@fluttergithubbot fluttergithubbot merged commit 66826e8 into flutter:master Mar 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
b605a46 
…r#98616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
890a491 
…r#98616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
b6073d0 
…r#98616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
bb23d5a 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
68f2dbf 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
c2edabb 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
0a04484 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
1c1c513 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
5f16c26 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
24378df 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
00f9db9 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
7f410f8 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
3e90e13 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
3b29419 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
66c643f 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
ba7b75d 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
73c6a3f 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
da99f92 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
16d3245 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
61f99ac 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
5bc78d2 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
1697339 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
3caabf1 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
1f12a7d 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
6b3e9dc 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
f0a93f8 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
4d953da 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
ecba64b 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
0bd9c1f 
…r#98616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
66826e8 Remove deprecated RenderObjectElement methods (flutter/flutte…
0b59fbc 
…r#98616)
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
@Piinks Piinks mentioned this pull request Mar 22, 2023
Closed
@goderbauer goderbauer mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: quality A truly polished experience c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @fluttergithubbot @goderbauer