Revert "Dismiss text selection toolbar with ESC" #98600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9407700.
flutter-dashboard
bot
added
a: text input
8 tasks
markusaksli-nc
deleted the
revert-98511-dimiss-text-selection-toolbar
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 16, 2022
Contributor
|
Ah sorry, I should have realized that would happen in code review. I think the action in EditableText can set its isEnabled based on whether or not the toolbar is currently visible. Then if the Autocomplete is showing its options, and the field is showing the selection toolbar, the first escape would close the toolbar, and the second would hide the options. I think that's the right behavior in that case. |
8 tasks
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
…tter#98600) This reverts commit 9407700.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out #98511 broke #97790 by always consuming the input @justinmc
I think the basic
CallbackActionalways consumes the input since it can't be disabled like_AutocompleteCallbackAction. Either way it broke the test for #97790 and should get reverted and fixed. I think the PR checker was behind ToT since I rebased just before #98511 landed.Reverts #98511