Skip to content

Remove deprecated Overflow and Stack.overflow #98583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Mar 8, 2022
Merged

Remove deprecated Overflow and Stack.overflow #98583

fluttergithubbot merged 2 commits into from
Mar 8, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022

This removes the Overflow enum as well as Stack.overflow.

This deprecated property has reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes a: quality A truly polished experience c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 16, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks changed the title [WIP] Remove deprecated Overflow and Stack.overflow Remove deprecated Overflow and Stack.overflow Feb 16, 2022
@Piinks Piinks requested a review from chunhtai February 16, 2022 21:02
@Hixie
Copy link
Contributor

Hixie commented Feb 16, 2022

test-exempt: removing code

Hixie
Hixie approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunhtai
chunhtai approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Contributor Author

Piinks commented Feb 18, 2022 •
edited
Loading

This still has 1 internal reference, working with the customer to resolve.

@fluttergithubbot fluttergithubbot merged commit 23ea512 into flutter:master Mar 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
2710c63 
…r#98583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
4b696d9 
…r#98583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
f860679 
…r#98583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
a579eab 
…r#98583)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Piinks @clocksmith
Remove deprecated Overflow and Stack.overflow (flutter#98583)
ab80c31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
32c2484 
…r#98583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
a4a1263 
…r#98583)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
ea8b67c 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
11ae37a 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
7f9cf5f 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
7625b80 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
a701fb5 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
57bb55e 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
20c8154 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
004a61f 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
d28bf6f 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
aae0d5b 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
d30698f 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
b2644c9 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
38f1d81 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
160626c 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
b97c38b 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
c1234f5 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
a43f88e 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
30d3806 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
5e2452d 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
ce912d4 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
02e4333 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
db2c50f 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
bc49ff6 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
f908912 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
0f9a759 
…r#98583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
23ea512 Remove deprecated Overflow and Stack.overflow (flutter/flutte…
21d51aa 
…r#98583)
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
@mockturtl mockturtl mentioned this pull request Apr 21, 2022
Open
@hlwhl hlwhl mentioned this pull request Oct 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: quality A truly polished experience c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @Hixie @chunhtai @fluttergithubbot