Skip to content

Dump backtrace when cannot attach to observatory #98550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 16, 2022
Merged

Dump backtrace when cannot attach to observatory #98550

fluttergithubbot merged 1 commit into from
Feb 16, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 16, 2022

When the tool launches the app, but can't connect to the observatory, print the backtrace of all threads before failing and killing the app. This could help detect deadlocks.

#97958 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 16, 2022
@jmagman jmagman self-assigned this Feb 16, 2022
@jmagman jmagman mentioned this pull request Feb 16, 2022
Closed
jmagman
jmagman commented Feb 16, 2022
View reviewed changes
packages/flutter_tools/lib/src/ios/ios_deploy.dart
try {
// Detach lldb from the app process.
_iosDeployProcess?.stdin.writeln('process detach');
_debuggerState = _IOSDeployDebuggerState.detached;
Copy link
Member Author

@jmagman jmagman Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle this state only in the log parser so logs can be printed until the app actually detaches.

@zanderso zanderso mentioned this pull request Feb 16, 2022
Closed
@fluttergithubbot fluttergithubbot merged commit cef6823 into flutter:master Feb 16, 2022
@jmagman jmagman deleted the bt-detach branch February 16, 2022 22:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
cef6823 Dump backtrace when cannot attach to observatory (flutter/flu…
55f6f00 
…tter#98550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
cef6823 Dump backtrace when cannot attach to observatory (flutter/flu…
34d35fc 
…tter#98550)
@jmagman jmagman mentioned this pull request Feb 23, 2022
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Dump backtrace when cannot attach to observatory (flutter#98550)
3b7f57d
@matanlurey matanlurey mentioned this pull request Jul 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @zanderso @fluttergithubbot