Skip to content

Remove deprecated DayPicker and MonthPicker #98543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Feb 23, 2022
Merged

Remove deprecated DayPicker and MonthPicker #98543

fluttergithubbot merged 3 commits into from
Feb 23, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022

This removes the following deprecated classes:

  • DayPicker
  • MonthPicker

This deprecated property has reached end of life after the release of Flutter 2.10

  • The replacement is CalendarDatePicker.
  • ❌ This migration is not supported by the dart fix tool.
  • 🕐 This API was deprecated in Material Date Picker redesign #50546, first tagged v1.26

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes a: quality A truly polished experience c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Feb 16, 2022
@Piinks Piinks changed the title [WIP] Remove deprecated DayPicker and MonthPicker Remove deprecated DayPicker and MonthPicker Feb 18, 2022
@Piinks Piinks requested a review from darrenaustin February 18, 2022 21:41
darrenaustin
darrenaustin approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@fluttergithubbot fluttergithubbot merged commit cddd552 into flutter:master Feb 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
cddd552 Remove deprecated DayPicker and MonthPicker (flutter/flutter#…
eb27638 
…98543)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
cddd552 Remove deprecated DayPicker and MonthPicker (flutter/flutter#…
60523a8 
…98543)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
cddd552 Remove deprecated DayPicker and MonthPicker (flutter/flutter#…
aae296e 
…98543)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Piinks @clocksmith
Remove deprecated DayPicker and MonthPicker (flutter#98543)
6725d6d
This was referenced Apr 11, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: quality A truly polished experience c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @darrenaustin @fluttergithubbot