Skip to content

Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced #98539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Mar 8, 2022
Merged

Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced #98539

fluttergithubbot merged 5 commits into from
Mar 8, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022 •
edited
Loading

This removes maxLengthEnforced from

  • CupertinoTextField
  • TextField
  • TextFormField

This deprecated property has reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Feb 16, 2022
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@Piinks Piinks changed the title [WIP]Remove deprecated [CupertinoTextField, TextField, TextFormField] maxLengthEnforced [WIP]Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Feb 16, 2022
@Piinks Piinks changed the title [WIP]Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced [WIP] Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Feb 16, 2022
@Piinks Piinks changed the title [WIP] Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Feb 18, 2022
@Piinks Piinks requested a review from justinmc February 18, 2022 21:33
@skia-gold
Copy link

skia-gold commented Feb 19, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/98539

@Piinks
Copy link
Contributor Author

Piinks commented Mar 3, 2022

This is pending one last customer change.

@Piinks Piinks requested a review from goderbauer March 3, 2022 22:37
goderbauer
goderbauer approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 7, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

justinmc
justinmc approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice, thanks for removing this!

It looks like there are Google test failures, I think they'll just need to be migrated to maxLengthEnforcement. Let me know if I can help with that.

@Piinks
Copy link
Contributor Author

Piinks commented Mar 7, 2022

Thank you! I have a cl out for review that will take care of the last one from Google testing.

@fluttergithubbot fluttergithubbot merged commit 5ae4885 into flutter:master Mar 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
1de0421 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
ef7af57 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
5eb2adc 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
aa74a37 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
df24bce 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
1d20bf6 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
b81cef2 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
b391372 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
c7324fd 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
c2df096 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
3d55cba 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
261ae6c 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
fe72bd3 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
bfd87b8 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
1b960e1 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
a08244f 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
429a5be 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
530436d 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
a493412 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
f6c1b14 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
43670dc 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
aa9aa3a 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
e08ea33 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
dc55b5e 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
dd13a83 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
6fef7d7 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
13c0cad 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
b5a77ff 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
56bfe1b 
…d maxLengthEnforced (flutter/flutter#98539)
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Piinks @skia-gold @fluttergithubbot @justinmc @goderbauer