Skip to content

CupertinoPicker: Update example #98525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 16, 2022
Merged

CupertinoPicker: Update example #98525

fluttergithubbot merged 1 commit into from
Feb 16, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 15, 2022

It would have been nice to have emojis for cool fruit picker example but look like dartpad doesn't support emoji

context: #93622 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 15, 2022
gspencergoog
gspencergoog approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 2097fe6 into flutter:master Feb 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
2097fe6 CupertinoPicker: Update example (flutter/flutter#98525)
b9c6a0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
2097fe6 CupertinoPicker: Update example (flutter/flutter#98525)
7054ac2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
2097fe6 CupertinoPicker: Update example (flutter/flutter#98525)
3ea1a93
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
2097fe6 CupertinoPicker: Update example (flutter/flutter#98525)
c3868ab
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
2097fe6 CupertinoPicker: Update example (flutter/flutter#98525)
de4564a
@TahaTesser TahaTesser deleted the remove-emojis-cp branch February 17, 2022 20:14
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
CupertinoPicker: Update example (flutter#98525)
e342c61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @gspencergoog @fluttergithubbot