Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Feb 15, 2022

No description provided.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 15, 2022
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm investigating why analyzer got downgraded in this change

@christopherfujino
Copy link
Contributor

We discussed the in discord that the downgrade is being constrained by DWDS.

Unrelated, it looks like there may be a Dart compilation failure with this change from CI:

packages/flutter_tools/lib/src/base/analyze_size.dart:152:51: Error: A value of type 'InputStreamBase?' can't be assigned to a variable of type 'InputStream?'.
 - 'InputStreamBase' is from 'package:archive/src/util/input_stream.dart' ('../.pub-cache/hosted/pub.dartlang.org/archive-3.2.0/lib/src/util/input_stream.dart').
 - 'InputStream' is from 'package:archive/src/util/input_stream.dart' ('../.pub-cache/hosted/pub.dartlang.org/archive-3.2.0/lib/src/util/input_stream.dart').
      final InputStream? rawContent = archiveFile.rawContent;
                                                  ^

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8822147140945870257/+/u/prepare_environment/download_dependencies/stdout

@bkonyi
Copy link
Contributor Author

bkonyi commented Feb 15, 2022

cc @elliette who is working on publishing an updated dwds with _fe_analyzer_shared: ^34.0.0

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@christopherfujino
Copy link
Contributor

Thanks for the fix. customer_testing on cirrus will unfortunately only be fixed by a rebase (not merge) upstream.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@zanderso
Copy link
Member

@bkonyi
Copy link
Contributor Author

bkonyi commented Feb 28, 2022

SkiaPerf is reporting a ~20ms improvement in DevFS sync time on this change

https://flutter-flutter-perf.skia.org/e/?begin=1644416127&end=1645923376&keys=Xcc07c667ee1ac557c92519d87dfab93f&requestType=0&xbaroffset=27644

Is that expected?

There weren't any changes in DDS or the service that should have impacted DevFS latency, but if we're seeing a consistent improvement I'm not going to complain... :-)

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants