Skip to content

Added viewport fraction parameter to tabView #98512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 11 commits into from
Mar 1, 2022
Merged

Added viewport fraction parameter to tabView #98512

fluttergithubbot merged 11 commits into from
Mar 1, 2022

Conversation

@Hari-07
Copy link
Contributor

@Hari-07 Hari-07 commented Feb 15, 2022 •
edited by Piinks
Loading

Added a parameter viewportFraction to make the viewportFraction of PageView used inside TabView customizable

Fixes #98506

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 15, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 15, 2022
@Hari-07 Hari-07 mentioned this pull request Feb 16, 2022
Closed
amanv8060
amanv8060 reviewed Feb 20, 2022
View reviewed changes
@Piinks Piinks self-requested a review February 23, 2022 13:44
@Piinks Piinks added the f: scrolling Viewports, list views, slivers, etc. label Feb 23, 2022
Piinks
Piinks reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hari-07 welcome! Thank you for the contribution.

packages/flutter/lib/src/material/tabs.dart Outdated
_updateTabController();
_currentIndex = _controller!.index;
_pageController = PageController(initialPage: _currentIndex!);
_pageController = PageController(initialPage: _currentIndex!, viewportFraction: widget.viewportFraction);
Copy link
Contributor

@Piinks Piinks Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style guide nit: more than one parameter should be split out over multiple lines

Suggested change
_pageController = PageController(initialPage: _currentIndex!, viewportFraction: widget.viewportFraction);
_pageController = PageController(
initialPage: _currentIndex!,
viewportFraction: widget.viewportFraction,
);

@Hari-07 Hari-07 requested a review from Piinks February 28, 2022 03:13
Piinks
Piinks approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thank you!

@jmagman
Copy link
Member

jmagman commented Mar 1, 2022

Google testing failures look like an unrelated flake. Manually marking as passing.

no such target '//testing/.../ios:IPHONE_8_PLUS_12_0': target 'IPHONE_8_PLUS_12_0' not declared in package

@fluttergithubbot fluttergithubbot merged commit 872e604 into flutter:master Mar 1, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
872e604 Added viewport fraction parameter to tabView (flutter/flutter…
584fdab 
…#98512)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
872e604 Added viewport fraction parameter to tabView (flutter/flutter…
39e8b92 
…#98512)
@Hari-07 Hari-07 deleted the tabview_issue_98506 branch March 1, 2022 22:54
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Hari-07 @clocksmith
Added viewport fraction parameter to tabView (flutter#98512)
ee9560a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

+1 more reviewer

@amanv8060 amanv8060 amanv8060 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make viewport width adjustable for tabView

6 participants

@Hari-07 @jmagman @Piinks @amanv8060 @werainkhatri @fluttergithubbot