Skip to content

Remove clipBehavior == Clip.none conditions #98503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 18, 2022
Merged

Remove clipBehavior == Clip.none conditions #98503

fluttergithubbot merged 1 commit into from
Feb 18, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 15, 2022

fixes #98487

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 15, 2022
@goderbauer
Copy link
Member

goderbauer commented Feb 15, 2022

/cc @Piinks

@Piinks Piinks self-requested a review February 16, 2022 23:59
Piinks
Piinks approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

Thank you for following up on this! :)

@TahaTesser TahaTesser force-pushed the remove-conditional-clipping branch from 732d205 to a0a9f6c Compare February 18, 2022 08:09
@fluttergithubbot fluttergithubbot merged commit c504797 into flutter:master Feb 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
c504797 Remove clipBehavior == Clip.none conditions (flutter/flutte…
f3c7fdf 
…r#98503)
@TahaTesser TahaTesser deleted the remove-conditional-clipping branch February 18, 2022 09:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 19, 2022
@engine-flutter-autoroll
c504797 Remove clipBehavior == Clip.none conditions (flutter/flutte…
3ddc741 
…r#98503)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Remove clipBehavior == Clip.none conditions (flutter#98503)
4ab89a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove clipBehavior == Clip.none conditions from widgets

4 participants

@TahaTesser @goderbauer @Piinks @fluttergithubbot