reads min/target sdk versions from localproperties #98450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
|
How to set this properties on CI server? the |
Contributor
Author
|
PTAL @christopherfujino |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
|
quick question do i just add the values in the flutter.buildMode=debug
flutter.versionName=1.0.0
flutter.versionCode=1
flutter.minSdkVersion=19
flutter.targetSdkVersion=31
flutter.compileSdkVersion=33like so or i'm missing something ? |
Contributor
|
@SPiercer Looks like this change was reverted in #99191. You can update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
build.gradlefiles to read theflutter.minSdkVersionandflutter.targetSdkVersionfrom the generated local.properties, and if not found, keep the default one (which is set at flutter.gradle)It changes all
build.gradlefiles from examples/* and the integration_test/example.It doesn't change
build.gradlefiles from dev projects at dev/* but they can be changed too upon further request.It changes both java and kotlin
build.gradletemplates.It changes the default app test to expect the new strings on
build.gradle.It doesn't apply the same concept to
flutter.compileSdkVersion, so having it onlocal.propertiesdoesn't change the value set atflutter.gradle, this can also be added upon further request.This PR also changes
flutter.gradleto detect and warn the developer with alogger.quietmessage about mismatches with plugins API level. If a mismatch is found, it also checks if the variablesflutter.minSdkVersionandflutter.targetSdkVersionwere set atlocal.propertiesIt also changes the
gradle_errors.dartto update the box message about how to fix the API level error, while adding a reference to the docs. The test was also updated.Images:
[Before] New project with a dependency requiring higher sdk version.
[After] New project with a dependency requiring higher sdk version.
[After] New project with the variables INcorrectly set at local.properties.
[After] New project with the variables correctly set at local.properties.
It closes #95533
Partially solves #95485 (Android part)
Could be a solution to #95514
Extra - Not related: at 0440790 I fixed the command required to export the
FLUTTER_ROOTvariable in order to run tests.