Added a NavgationBar example with nested Navigators #98440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
chunhtai
reviewed
Feb 15, 2022
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Mostly looks good, left some comments
| if (destinationFaders[index].isAnimating) { | ||
| return IgnorePointer(child: view); | ||
| } | ||
| return Offstage(child: view); |
Contributor
There was a problem hiding this comment.
We can wrap all child with Offstage and toggle the flag instead
Contributor
Author
There was a problem hiding this comment.
Good idea, that way the tree doesn't need to change.
| title: Text('${destination.title} AlertDialog'), | ||
| actions: <Widget>[ | ||
| TextButton( | ||
| onPressed: () { Navigator.pop(context, 'OK'); }, |
Contributor
Author
There was a problem hiding this comment.
Good point, there's no need for the 'OK' argument.
added 2 commits
February 15, 2022 10:56
chunhtai
approved these changes
Feb 15, 2022
| title: Text('${destination.title} AlertDialog'), | ||
| actions: <Widget>[ | ||
| TextButton( | ||
| onPressed: () { Navigator.pop(context); }, |
Contributor
Author
There was a problem hiding this comment.
Personally, I prefer to only use the => notation for functions that return a value.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 15, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
|
When running this on iOS, scroll to top functionality doesn't work when tapping the status bar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example of a NavigationBar where each destination is managed by a nested Navigator.
Try the example in DartPad: https://dartpad.dev/?id=37a8f13c000cf229857f6c36b4a55ee6
Addresses issues raised in #18740. Similar examples to come for NavigationRail, BottomNavigationBar, and TabBar.