-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Remove unused parameter and consequently unused variable #98428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused parameter and consequently unused variable #98428
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change @mateusfccp re the issue, you can just open a blank one (or follow any of the links above and ignore the template). It's just useful to have an issue in case the PR gets reverted (e.g. due to unrelated infra issues) so we don't forget to reland it. |
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the cleanup!
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secondary LGTM 😉

The method
_startHeroTransition, fromHeroController, receives anAnimation<double> animation, but does nothing with it. This PR removes the parameter.Consequently, it removes the
animationvariable from_maybeStartHeroTransition, as it was being created only to be passed to_startHeroTransition. The conditional that would create this variable depending on the hero type could then be merged into the switch below.Fixes #98548
Pre-launch Checklist
///).