Skip to content

Avoid unnecessary lambdas in SelectionOverlay.showHandles() #98409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tgucio wants to merge 95 commits into from
Closed

Avoid unnecessary lambdas in SelectionOverlay.showHandles() #98409

tgucio wants to merge 95 commits into from

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented Feb 14, 2022

This PR removes the unnecessary lambdas in SelectionOverlay method showHandles().

No functional changes.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 14, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 14, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@LongCatIsLooong
Copy link
Contributor

LongCatIsLooong commented Feb 14, 2022

Hi @Hixie could you take a look at this pull request? It doesn't seem to be testable. Also I remember we have policies regarding accepting trivial (syntactic-sugar-only) changes, but I could find it in the wiki.

engine-flutter-autoroll and others added 22 commits February 14, 2022 11:55
@engine-flutter-autoroll
Roll Engine from b63614c to 6f4d644 (1 revision) (#98433)
79df99d
@TahaTesser
Add CupertinoSlider example (#93633)
19a380f
@engine-flutter-autoroll
Roll Engine from 6f4d644 to a110338 (1 revision) (#98441)
4d9e6d9
@TahaTesser
CupertinoActionSheet: Update sample (#98356)
7d21dbf
@TahaTesser
CupertinoAlertDialog: Update sample (#98357)
513c6cd
@engine-flutter-autoroll
Roll Engine from a110338 to 25ab571 (4 revisions) (#98447)
1ae5dd1
@christopherfujino
rename two unit tests that were not actually being run on CI (#98299)
87fe3fe
@keyonghan
Enable fullscreen_textfield_perf tests in prod (#98453)
381cb28
@engine-flutter-autoroll
Roll Engine from 25ab571 to 8714a24 (2 revisions) (#98459)
894ef49
@engine-flutter-autoroll
Roll Engine from 8714a24 to 20bd78c (2 revisions) (#98465)
06bf6a1
@engine-flutter-autoroll
Roll Engine from 20bd78c to c9cb315 (2 revisions) (#98468)
ff425fc
@TahaTesser
Add custom size constraints parameter to PopupMenu (#97798)
ccaf515
@darrenaustin
Migrate NavigationBar to M3 tokens. (#98285)
ca2a751
@engine-flutter-autoroll
Roll Engine from c9cb315 to ca15cd5 (1 revision) (#98474)
9f33bb0
@engine-flutter-autoroll
Roll Engine from ca15cd5 to e683e0c (2 revisions) (#98485)
6985b78
@TahaTesser
Add CupertinoPicker interactive example (#93622)
ee0bbf4
@bkonyi
Update flutter_tools to look for new VM service message (#97683)
2a2f973 
* Update flutter_tools to look for new VM service message

The Dart SDK will soon move away from the current Observatory message:

"Observatory listening on ..."

To a new message that no longer references Observatory:

"Dart VM Service listening on ..."

This change updates all tests with mocks to check for the new message
and also adds support for the new message in ProtocolDiscovery.

See dart-lang/sdk#46756

* Fix some parsing locations

* Fix analysis failures

* Update message

* Remove extra comment

* Update message

* Add globals prefix
@TahaTesser
Add ExpansionTileTheme (#98405)
60f039c
@TahaTesser
Update CupertinoTextField example (#93738)
dfd4244
@TahaTesser
CupertinoSegmentedControl: Add an interactive example (#98154)
7943ae5
@TahaTesser
CupertinoSlidingSegmentedControl: Add an interactive example (#98156)
fd4b1e8
@engine-flutter-autoroll
Roll Plugins from 6b0d4549eaa5 to c48a5f87757d (8 revisions) (#98504)
1a0e5c5
engine-flutter-autoroll and others added 25 commits February 17, 2022 19:44
@engine-flutter-autoroll
Roll Engine from c5e89cb to 605454e (3 revisions) (#98718)
c50b02f
@engine-flutter-autoroll
Roll Engine from 605454e to 0fd7713 (3 revisions) (#98727)
02a182d
@engine-flutter-autoroll
Roll Engine from 0fd7713 to 9ef819b (1 revision) (#98734)
0ed7fc8
@TahaTesser
Remove clipBehavior == Clip.none conditions (#98503)
c504797
@engine-flutter-autoroll
Roll Engine from 9ef819b to c8d15c3 (1 revision) (#98736)
9fa4275
@TahaTesser
Show RefreshIndicator on top when scroll's axis direction is up (ma…
14a406f 
…tching native behaviour) (#93779)
@engine-flutter-autoroll
Roll Plugins from ed29396208cd to 1e7af5e1d66b (6 revisions) (#98751)
a554dc5
@engine-flutter-autoroll
Roll Engine from c8d15c3 to 7c9b1d6 (5 revisions) (#98754)
5d575d9
@christopherfujino
[flutter_tools] remove flaky web vm service test (#98540)
081d960
@bkonyi
Update dependencies to pull in new vm_service, dds, dwds, coverage, e…
50c4720 
…tc (#98513)
@bkonyi
Reland "Enable caching of CPU samples collected at application startup (
4add01a 
#89600)" (#98769)

This reverts commit ac3c443.
@Piinks
Remove deprecated VelocityTracker constructor (#98541)
f9921eb
Improve Gradle retry logic (#96554)
c8266d3
@engine-flutter-autoroll
Roll Engine from 7c9b1d6 to bad5588 (4 revisions) (#98768)
587bbd5
@dependabot
Bump ossf/scorecard-action from 1.0.3 to 1.0.4 (#98771)
a059a38
@christopherfujino
[flutter_conductor] fix auto-tagging branch point (#98618)
74881c1
@christopherfujino
[flutter_tools] deprecate the dev branch from the feature system (#98689
4b2e828 
)
@goderbauer
Add more tests to slider to avoid future breakages (#98772)
baa2803
@zanderso
Revert "Add more tests to slider to avoid future breakages (#98772)" (#…
9aed298 
…98783)

This reverts commit baa2803.
@engine-flutter-autoroll
Roll Engine from bad5588 to e0d70c0 (2 revisions) (#98777)
44848b9
@engine-flutter-autoroll
Roll Engine from e0d70c0 to f6ea618 (8 revisions) (#98784)
c849844
@zanderso
Revert "Reland "Enable caching of CPU samples collected at applicatio…
54a9d65 
…n startup (#89600)"" (#98803)
@engine-flutter-autoroll
Roll Plugins from 1e7af5e1d66b to d9fc677ab06f (4 revisions) (#98870)
617de91
@tgucio
Avoid unnecessary lambdas in showHandles()
ad07032
@tgucio
Merge branch 'text-selection-lambdas' of github.com:tgucio/flutter in…
75a037e 
…to text-selection-lambdas
@tgucio
Copy link
Contributor Author

tgucio commented Feb 22, 2022

Rebase error... will submit a new PR to fix.

@tgucio tgucio closed this Feb 22, 2022
@tgucio tgucio mentioned this pull request Feb 22, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@goderbauer goderbauer goderbauer approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.