-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add ExpansionTileTheme
#98405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpansionTileTheme
#98405
Conversation
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good however the API doc for ExpansionTile's properties should be updated to reflect the new ExpansionTileTheme dependencies.
| ]); | ||
| }); | ||
|
|
||
| testWidgets('default ExpansionTile debugFillProperties', (WidgetTester tester) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #97647
Adding this theme will help with the Material 3 migration: #91605.
minimal code sample
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.