Skip to content

Fix fooTheme.of(context); usage docs #98402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 2 commits into from
Feb 14, 2022
Merged

Fix fooTheme.of(context); usage docs #98402

HansMuller merged 2 commits into from
Feb 14, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 14, 2022 •
edited
Loading

fixes #98401

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 14, 2022
r-mzy47
r-mzy47 reviewed Feb 14, 2022
View reviewed changes
HansMuller
HansMuller approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice catch!

@HansMuller HansMuller merged commit 7c1baea into flutter:master Feb 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
1d326d2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
c060306
@TahaTesser TahaTesser deleted the fix-theme-usage-docs branch February 14, 2022 17:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
4636c40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
2148b20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
4cbbc65
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
4e4e7fb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
fcd431a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
94b2792
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
3089afa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
d0b1136
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
0be3411
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
4f584c9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
0229c48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
41d4e1e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
93cf49b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
5b48c0b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
bd06bd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
c80b520
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
7c1baea Fix fooTheme.of(context); usage docs (flutter/flutter#98402)
3877a07
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Fix fooTheme.of(context); usage docs (flutter#98402)
541784c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@r-mzy47 r-mzy47 r-mzy47 left review comments

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix fooTheme.of(context); usage docs

3 participants

@TahaTesser @HansMuller @r-mzy47