Skip to content

Add explanation to ChangeNotifier #98295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 16, 2022
Merged

Add explanation to ChangeNotifier #98295

fluttergithubbot merged 1 commit into from
Feb 16, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Feb 11, 2022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 11, 2022
@chunhtai chunhtai requested review from Hixie and goderbauer February 11, 2022 23:07
Hixie
Hixie approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test-exempt: only affects comments

goderbauer
goderbauer approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 12, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 286c975 into flutter:master Feb 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
286c975 Add explanation to ChangeNotifier (flutter/flutter#98295)
a798ad2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
286c975 Add explanation to ChangeNotifier (flutter/flutter#98295)
5967308
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
286c975 Add explanation to ChangeNotifier (flutter/flutter#98295)
c510b41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
286c975 Add explanation to ChangeNotifier (flutter/flutter#98295)
e30c1fa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
286c975 Add explanation to ChangeNotifier (flutter/flutter#98295)
3037a1b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
286c975 Add explanation to ChangeNotifier (flutter/flutter#98295)
08e68df
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@chunhtai @clocksmith
Add explanation to ChangeNotifier (flutter#98295)
0d37514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chunhtai @fluttergithubbot @Hixie @goderbauer