[flutter_tools] do not validate maven upstream if cloud storage override provided #98293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
christopherfujino
changed the title
christopherfujino
changed the title
Jasguerrero
reviewed
Feb 15, 2022
| ]; | ||
|
|
||
| /// MacOS specific required HTTP hosts. | ||
| const List<String> macOSRequiredHttpHosts = <String>[ |
Contributor
There was a problem hiding this comment.
Should the macOSRequiredHttpHosts changed to a method as well to keep it consistent with the android?
Contributor
Author
There was a problem hiding this comment.
I don't think so, since it would be a function that takes no parameters and always returns the same value. In the end, I guess it's a style choice.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
christopherfujino
deleted the
update-http-host-validator-to-make-maven-conditional
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 15, 2022
…ge override provided (flutter/flutter#98293)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Hixie
reviewed
Feb 9, 2023
| List<String> androidRequiredHttpHosts(Platform platform) { | ||
| return <String>[ | ||
| // If kEnvCloudUrl is set, it will be used as the maven host | ||
| if (!platform.environment.containsKey(kEnvCloudUrl)) |
Contributor
There was a problem hiding this comment.
Should we check for kEnvCloudUrl in this case?
Contributor
There was a problem hiding this comment.
oh i see we always add that one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user provides the
FLUTTER_STORAGE_BASE_URLenv variable, this will be used as the maven host URL. However, the flutter http host doctor validator would still try to validate the upstream maven URL.This PR updates the validator to only check the upstream maven host if
FLUTTER_STORAGE_BASE_URLis NOT provided.Fixes #98170