[performance] Trace direct calls to inflateWidget #98277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
framework
| Element inflateWidget(Widget newWidget, Object? newSlot) { | ||
| assert(newWidget != null); | ||
|
|
||
| if (!kReleaseMode && debugProfileBuildsEnabled) { |
Contributor
There was a problem hiding this comment.
are profiles even useful with this much debug code running?
Member
Author
There was a problem hiding this comment.
In profile mode, this will only add the Widget's name to the timeline if debugProfileBuildsEnabled is manually enabled. (Only in debug mode do you also get extra "timeline arguments" from the diagnostics mode...)
It's sort of the point of the debugProfileBuildsEnabled option to get you that extra information in profile mode at the expense of skewing with performance numbers, which is documented on the flag.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
Member
|
Note that this PR increased the stack size per nesting level: |
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
Elements in the framework and in the outside world callinflateWidgetdirectly instead of going throughupdateChildto inflate widgets. Widgets inflated that way did not show up in tracing withdebugProfileBuildsEnabledbecause onlyupdateChildwas instrumented with tracing. This PR moves the instrumentation toinflateWidgetto trace all widgets inflations - whether they are triggered viaupdateChildor directly viainflateWidget.The most notable Element in the framework that's going straight to
inflateWidgetisMultiChildRenderObjectElement:flutter/packages/flutter/lib/src/widgets/framework.dart
Line 6451 in 4f975cb
MultiChildRenderObjectElementpowers common widgets likeRow,Column, andStackamong many others - all of which had their direct children omitted from traces. But no more!