Skip to content

Conversation

@zanderso
Copy link
Member

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how that could be related, it failed on a host chrome test.

 Exception: Process exited prematurely: run --machine -d chrome --web-run-headless --verbose --web-renderer=html --start-paused: 

But let's revert I guess and see what happens.

@zanderso zanderso merged commit 81b9c35 into master Feb 11, 2022
@zanderso zanderso deleted the revert-98144-yusuf-goog-patch-1 branch February 11, 2022 17:30
@godofredoc
Copy link
Contributor

Reverts #98144

Mac web_tool_tests is failing repeatedly after this commit. That test also failed in presubmit on the same PR: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20web_tool_tests/12308/overview.

Interesting the next build passed correctly https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20web_tool_tests/12309/overview @yusuf-goog can you please check the difference in between those two builds.

@jmagman
Copy link
Member

jmagman commented Feb 11, 2022

Should probably file an issue for the web team to look at, I'm skeptical changing Xcode and the macOS version would make a chrome test flaky (not consistently failing).

@zanderso
Copy link
Member Author

I filed #98278

@yusuf-goog
Copy link
Contributor

I opened up #98279 against the web team.

@yusuf-goog
Copy link
Contributor

Closing #98279 against duplicate #98278

@zanderso
Copy link
Member Author

All the pre- and post- submit builds that have picked up this revert so far have been passing.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@jmagman
Copy link
Member

jmagman commented Feb 11, 2022

Re-landing in #98297.
See also #98278 for the web test flake.

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants