Skip to content

PointerDeviceKind forwards-compatibility in flutter_test #98202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 11, 2022
Merged

PointerDeviceKind forwards-compatibility in flutter_test #98202

fluttergithubbot merged 1 commit into from
Feb 11, 2022

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Feb 10, 2022

This use of PointerDeviceKind was missed in #97350

Needed to reland flutter/engine#28571
Original issue is #23604

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 10, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 10, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dkwingsmt
dkwingsmt approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need a second review

Hixie
Hixie approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test-exempt: temporary avoidance of analysis errors to allow code to land

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 10, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 3f9c0e7 into flutter:master Feb 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
3f9c0e7 PointerDeviceKind forwards-compatibility in flutter_test (flu…
294ba56 
…tter/flutter#98202)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
3f9c0e7 PointerDeviceKind forwards-compatibility in flutter_test (flu…
3891bb9 
…tter/flutter#98202)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
3f9c0e7 PointerDeviceKind forwards-compatibility in flutter_test (flu…
d1f6e47 
…tter/flutter#98202)
@moffatman moffatman mentioned this pull request Feb 11, 2022
Merged
8 tasks
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@moffatman @clocksmith
PointerDeviceKind forwards-compatibility in flutter_test (flutter#98202)
3e1bc4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moffatman @fluttergithubbot @Hixie @dkwingsmt