Skip to content

Pin url_launcher to federated version in plugin_lint_mac #98171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Feb 11, 2022
Merged

Pin url_launcher to federated version in plugin_lint_mac #98171

jmagman merged 2 commits into from
Feb 11, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 10, 2022 •
edited
Loading

Fixes #98165

Pins to url_launcher to first federated version flutter/plugins#4536. See explanation at #98165 (comment)

Reverts #98166

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Feb 10, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 10, 2022
@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Tests are failing on infra issue #97303.

@jmagman jmagman mentioned this pull request Feb 10, 2022
Merged
cyanglaz
cyanglaz approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the infra issue is fixed and tests pass

This was referenced Feb 10, 2022
Closed
Merged
@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Rebased onto #98210.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Test failed because it still ran on Mac-10.15 even on #98210, and flutter/cocoon#1597 probably hadn't rolled in cocoon.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

led run https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/2a0cbcfe951621b38908a6c4fa44e2af325a8107877e37859c0b4f2b534eb49d/+/build.proto?server=chromium-swarm.appspot.com

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Ugh, led test still failed. #98166 passed let's merge that one instead of this one to reopen the tree, I'll keep investigating this.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Feb 11, 2022

Except the new version of url_launcher was published about an hour ago :(

@keyonghan
Copy link
Contributor

keyonghan commented Feb 11, 2022

The os dimension is being retrieved on platform property level, so unfortunately c1c96ef did not promote the dimension.

So we need to wait for #98144 to land, so that the new os versions will be picked up.

@jmagman
Copy link
Member Author

jmagman commented Feb 11, 2022

The os dimension is being retrieved on platform property level, so unfortunately c1c96ef did not promote the dimension.

So we need to wait for #98144 to land, so that the new os versions will be picked up.

It looks like it worked this time?
https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11051?

os | "Mac-12"
...
xcode | "13a233"

It ran on a Mac-12.2 (build835-m9) machine.

@jmagman jmagman merged commit ac708f1 into flutter:master Feb 11, 2022
@jmagman jmagman deleted the url-launcher branch February 11, 2022 02:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ac708f1 Pin url_launcher to federated version in plugin_lint_mac (flu…
acb3800 
…tter/flutter#98171)
This was referenced Feb 11, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ac708f1 Pin url_launcher to federated version in plugin_lint_mac (flu…
f6fbd72 
…tter/flutter#98171)
This was referenced Feb 11, 2022
Merged
Merged
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ac708f1 Pin url_launcher to federated version in plugin_lint_mac (flu…
4b9f13d 
…tter/flutter#98171)
This was referenced Feb 11, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ac708f1 Pin url_launcher to federated version in plugin_lint_mac (flu…
0abc1a8 
…tter/flutter#98171)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ac708f1 Pin url_launcher to federated version in plugin_lint_mac (flu…
0ddde23 
…tter/flutter#98171)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ac708f1 Pin url_launcher to federated version in plugin_lint_mac (flu…
f1f9e40 
…tter/flutter#98171)
@keyonghan
Copy link
Contributor

keyonghan commented Feb 11, 2022

It looks like it worked this time? https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11051?

os | "Mac-12"
...
xcode | "13a233"

It ran on a Mac-12.2 (build835-m9) machine.

Ah, right. The pre-submit should be okay as scheduling is triggered via cocoon which started supporting dimension injection yesterday. The post-submit needs to wait for that PR to land as it doesn't support target level override.

Created #98274 to track.

@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Feb 18, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Pin url_launcher to federated version in plugin_lint_mac (flutter#98171)
7b85648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac plugin_lint_mac failing consistently on unrelated PR

4 participants

@jmagman @stuartmorgan-g @keyonghan @cyanglaz