-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Revert "Update plugin lint test for federated url_launcher plugin" #98166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This test hit infra issue #97303 |
|
#98171 is a better fix, keeping this open for now but will close when infra issues unwedge and that one can merge. |
4086af0 to
4d0235a
Compare
|
#98171 is still failing, let's merge this one to reopen the tree, and I'll keep investigating. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
|
Merging on red. |
…ugin (flutter#94374)" (flutter#98166)" This reverts commit ea6025c.
…utter#94374)" (flutter#98166) This reverts commit 86b80d1.
Reverts #94374
#98165
url_launcherbecame unfederated somehow. Temporarily reverting this to re-open the tree.#98165
Test that needs to pass: https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11005