Skip to content

[integration_test] Fix official example for Android #98162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 11, 2022
Merged

[integration_test] Fix official example for Android #98162

fluttergithubbot merged 1 commit into from
Feb 11, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 9, 2022

fixes #98161

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the f: integration_test The flutter/packages/integration_test plugin label Feb 9, 2022
@jmagman
Copy link
Member

jmagman commented Feb 10, 2022

/cc @blasten

blasten
blasten approved these changes Feb 10, 2022
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Feb 10, 2022

Please rebase onto #98166 to fix plugin_lint_mac.

@jmagman
Copy link
Member

jmagman commented Feb 11, 2022

Please rebase onto #98166 to fix plugin_lint_mac.

Actually make that #98171.

@fluttergithubbot fluttergithubbot merged commit ae6ace3 into flutter:master Feb 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ae6ace3 [integration_test] Fix official example for Android (flutter/…
5e53596 
…flutter#98162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ae6ace3 [integration_test] Fix official example for Android (flutter/…
5a8d2d9 
…flutter#98162)
@TahaTesser TahaTesser deleted the fix-integration-test-android-example branch February 11, 2022 12:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ae6ace3 [integration_test] Fix official example for Android (flutter/…
6b75cd0 
…flutter#98162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ae6ace3 [integration_test] Fix official example for Android (flutter/…
9f39007 
…flutter#98162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
ae6ace3 [integration_test] Fix official example for Android (flutter/…
c50508f 
…flutter#98162)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
[integration_test] Fix official example for Android (flutter#98162)
a784b00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: integration_test The flutter/packages/integration_test plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[integration_test] Fix official example for Android

4 participants

@TahaTesser @jmagman @blasten @fluttergithubbot