Skip to content

Add benchmark to property #98159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Feb 11, 2022
Merged

Add benchmark to property #98159

fluttergithubbot merged 3 commits into from
Feb 11, 2022

Conversation

@KristinBi
Copy link
Contributor

@KristinBi KristinBi commented Feb 9, 2022

Add the benchmark to property. Let benchmark to be true to show that this build is a benchmark test.

Referred to #98004 for all benchmark tests.

@KristinBi KristinBi added the team: benchmark Performance issues found by inspecting benchmarks label Feb 9, 2022
@KristinBi KristinBi self-assigned this Feb 9, 2022
CaseyHillers
CaseyHillers suggested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on changing the .ci.yaml for now. Let's land the changes to Cocoon first, and test them before changing the prod configs

@keyonghan
Copy link
Contributor

keyonghan commented Feb 10, 2022 •
edited
Loading

Let's hold off on changing the .ci.yaml for now. Let's land the changes to Cocoon first, and test them before changing the prod configs

These are target properties and should be no-op changes?

@KristinBi There is a failed check, which may need cocoon side fix.

FormatException: Protobuf JSON decoding failed at: root["targets"]["27"]["properties"]["benchmark"]. Expected String value

@keyonghan
Copy link
Contributor

keyonghan commented Feb 10, 2022

Instead of benchmark: true, we should use benchmark: "true"

CaseyHillers
CaseyHillers reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Keyong's comment, this LGTM otherwise

@CaseyHillers CaseyHillers self-requested a review February 10, 2022 20:27
CaseyHillers
CaseyHillers approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to remove the request changes. Please wait on Keyong's approval before landing.

keyonghan
keyonghan approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark property is populating to the build:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_benchmarks_html/9744/overview (see Input Properties)

Let's land this. LGTM.

@keyonghan
Copy link
Contributor

keyonghan commented Feb 10, 2022

@KristinBi We need to wait for all tests pass, and then add label Waiting for Tree to go green and let bot auto submit.

@KristinBi
Copy link
Contributor Author

KristinBi commented Feb 10, 2022

Thanks Keyong and Casey, I will add the label later to let it auto submit.

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 10, 2022
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Feb 10, 2022

Re Mac plugin_lint_mac, you'll need to rebase this branch on tip of tree to get the fix for that breakage.

@KristinBi KristinBi force-pushed the distinguish-benchmark branch from 198f784 to 5292220 Compare February 11, 2022 00:30
@jmagman
Copy link
Member

jmagman commented Feb 11, 2022

Re Mac plugin_lint_mac, you'll need to rebase this branch on tip of tree to get the fix for that breakage.

Sorry, make that #98171.

@KristinBi KristinBi force-pushed the distinguish-benchmark branch from 1385196 to 3f24659 Compare February 11, 2022 09:38
@fluttergithubbot fluttergithubbot merged commit e907b03 into flutter:master Feb 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
a6416b8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
581a572
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
a565620
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
0f37098
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
a7066f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
1009293
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
17be79a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
e907b03 Add benchmark to property (flutter/flutter#98159)
87dbaac
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@KristinBi @clocksmith
Add benchmark to property (flutter#98159)
adee48b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@KristinBi KristinBi

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team: benchmark Performance issues found by inspecting benchmarks team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@KristinBi @keyonghan @CaseyHillers @jmagman @goderbauer @fluttergithubbot