Skip to content

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Feb 9, 2022

  • Updated the Material Design tokens to v0.81.
  • Removed some unused token files for Floating Action Button.
  • Cleaned up base template class and its utility methods.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 9, 2022
@darrenaustin darrenaustin requested review from HansMuller, guidezpl and rami-a and removed request for HansMuller February 9, 2022 21:06
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Feb 10, 2022

Please rebase onto #98166 to fix plugin_lint_mac.

@darrenaustin
Copy link
Contributor Author

Please rebase onto #98166 to fix plugin_lint_mac.

Thanks, I thought I had picked it up, but apparently I just missed it. I'll rebase again.

@jmagman
Copy link
Member

jmagman commented Feb 11, 2022

Please rebase onto #98166 to fix plugin_lint_mac.

Thanks, I thought I had picked it up, but apparently I just missed it. I'll rebase again.

Sorry actually it broken again, fix is at #98171.

@darrenaustin
Copy link
Contributor Author

Sorry actually it broken again, fix is at #98171.

That would explain why it didn't work for me 😄. I just rebased again and it looks like it is now failing for a new reason. I will pick this up again tomorrow. Thx for following up on this and for the fixes.

@darrenaustin darrenaustin merged commit 21a6c06 into flutter:master Feb 11, 2022
@darrenaustin darrenaustin deleted the token_update_0.81 branch February 11, 2022 06:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants