Skip to content

Fix flutter gen-l10n help message #98147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 11, 2022
Merged

Fix flutter gen-l10n help message #98147

fluttergithubbot merged 1 commit into from
Feb 11, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 9, 2022

fixes #97430

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 9, 2022
christopherfujino
christopherfujino approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Feb 10, 2022

Please rebase onto #98166 to fix plugin_lint_mac.

@jmagman
Copy link
Member

jmagman commented Feb 11, 2022

Please rebase onto #98166 to fix plugin_lint_mac.

Sorry actually it broken again, fix is at #98171.

@fluttergithubbot fluttergithubbot merged commit d6d3283 into flutter:master Feb 11, 2022
@TahaTesser TahaTesser deleted the fix-gen-l10-help-message branch February 11, 2022 09:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
c1350ec
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
fafda86
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
2dec015
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
41cc3a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
a6b3ba5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
d8894cf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
764d23e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
2f5137f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
d6d3283 Fix flutter gen-l10n help message (flutter/flutter#98147)
242ea5d
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Fix flutter gen-l10n help message (flutter#98147)
dc5a2a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong help message in flutter gen-l10n

4 participants

@TahaTesser @jmagman @christopherfujino @fluttergithubbot