Support Samsung phone when getting device wakefulness status
#98146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
godofredoc
reviewed
Feb 9, 2022
Contributor
There was a problem hiding this comment.
Can we just add the new check to the existing regular expression? e.g mWakefulness=|getWakefullnessLocked()=
Contributor
Author
There was a problem hiding this comment.
Used regexp to combine these two.
godofredoc
approved these changes
Feb 9, 2022
Member
|
Please rebase onto #98166 to fix plugin_lint_mac. |
keyonghan
force-pushed
the
getwakefullness_update
branch
from
1bfea4a to
5352176
Compare
keyonghan
force-pushed
the
getwakefullness_update
branch
from
5352176 to
8802dad
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current device assumes single pattern on all devices, and uses
mWakefulness=Awaketo get the wakefulness status. This fails when it's a Samsung phone, which returnsgetWakefullnessLocked()=Awake.This PR adds support for Samsung phones.
Fixes: #97235