Update Xcode version to 13a233 #98144
Conversation
Update Xcode version to 13a233 for mac builders.
|
For #94078 |
| device_type: none | ||
| mac_model: Macmini8,1 | ||
| xcode: 12c33 | ||
| xcode: 13a233 |
There was a problem hiding this comment.
OS will also need to get changed to 12.0.1
There was a problem hiding this comment.
Fixed, set to 12.2, which is the new version deployed.
There was a problem hiding this comment.
Per @jmagman I changed all the mac builders to be at Mac-12, rather then pegged at a more specific version.
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
LGTM but let's wait for the ongoing release to get completed.
|
Why did https://ci.chromium.org/p/flutter/builders/try/Mac%20build_aar_module_test/13799 run on a Mac-10.15.7 machine? https://chromium-swarm.appspot.com/bot?id=build887-m9 |
That's a devicelab test that we run on presubmit, .ci.yaml also needs an update for this test. |
|
FYI tests are failing on: |
|
Is there a good reason to peg it to specifically Mac-12.2? Should we set it to Mac-12? |
I don't have a preference, this Lines 109 to 111 in 0ce527e |
Does that mean it will work post-merge once .ci.yaml config changes land? This failure, for example, isn't in the devicelab: https://ci.chromium.org/p/flutter/builders/try/Mac%20build_tests_2_4/15803 |
Mac_build tests are hostonly tests, they use different .ci.yaml configurations from devicelab tests. All the tests need to pass on presubmit and as long as we keep half of the capacity running on 10.15 we should not break postsubmit tests as after landing the PR, postsubmit tests will still use the old configs for ~45mins until they are propagated. Once the configs are fully propagated it will be safe to upgrade the remaining machines. |
|
New version of cocoon has been deploy with flutter/cocoon#1597. |
|
#98210 override should also be reverted on this change. |
Though I can to it in a follow-up. |
goderbauer
added
c: contributor-productivity
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
It looks like this is breaking the Mac web_tool_tests on the framework tree. Revert is here #98263. |
This reverts commit 84fcb15.
8 participants
Update Xcode version to 13a233 for mac builders.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.