Skip to content

Revert "[EditableText] honor the "brieflyShowPassword" system setting" #98089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 1 commit into from
Feb 9, 2022
Merged

Revert "[EditableText] honor the "brieflyShowPassword" system setting" #98089

godofredoc merged 1 commit into from
Feb 9, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Feb 9, 2022

Reverts #97769 this PR broke the tree.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 9, 2022
@itsjustkevin itsjustkevin self-requested a review February 9, 2022 04:10
@godofredoc godofredoc merged commit 3bdea6b into master Feb 9, 2022
@godofredoc godofredoc deleted the revert-97769-editableText-breiflyShowPassword branch February 9, 2022 04:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
4b10b80 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
41262b3 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
cca67a7 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
2d22ed3 
… setting (#97769)" (flutter/flutter#98089)
This was referenced Feb 9, 2022
Merged
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
9afab1d 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
861e39f 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
4cda6ff 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
8221e73 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
49da027 
… setting (#97769)" (flutter/flutter#98089)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
3bdea6b Revert "[EditableText] honor the "brieflyShowPassword" system…
c389407 
… setting (#97769)" (flutter/flutter#98089)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@godofredoc @clocksmith
Revert "[EditableText] honor the "brieflyShowPassword" system setting (…
dfbc9b0 
…flutter#97769)" (flutter#98089)

This reverts commit 63f48d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsjustkevin itsjustkevin itsjustkevin approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

@justinmc justinmc Awaiting requested review from justinmc

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @itsjustkevin