Skip to content

Split complexity scoring tests into two tasks - one for Android and one for iOS #98063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gw280 merged 3 commits into from
Feb 9, 2022
Merged

Split complexity scoring tests into two tasks - one for Android and one for iOS #98063

gw280 merged 3 commits into from
Feb 9, 2022

Conversation

@gw280
Copy link
Contributor

@gw280 gw280 commented Feb 8, 2022 •
edited
Loading

Split picture_cache_complexity_scoring_perf__timeline_summary into two tasks - one for Android and one for iOS

#86728

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • [x ] I signed the CLA.
  • [x ] I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gw280 gw280 requested a review from keyonghan February 8, 2022 21:48
@gw280 gw280 requested a review from CaseyHillers as a code owner February 8, 2022 21:48
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 8, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 8, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

keyonghan
keyonghan approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gw280 gw280 merged commit 8b944ea into flutter:master Feb 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
039e75d 
…id and one for iOS (flutter/flutter#98063)
This was referenced Feb 9, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
5cda233 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
3d0d42e 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
8d656bb 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
077008f 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
1d134ea 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
28680a5 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
da211ad 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
800ce4a 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
6c0678b 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
1388e05 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
547ddba 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
2116bc7 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
7d1c934 
…id and one for iOS (flutter/flutter#98063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
8b944ea Split complexity scoring tests into two tasks - one for Andro…
e0547ec 
…id and one for iOS (flutter/flutter#98063)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Split complexity scoring tests into two tasks - one for Android and o…
dc7fa90 
…ne for iOS (flutter#98063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gw280 @keyonghan